Skip to content

ARROW-6318: [Integration] Run tests against pregenerated files#5272

Closed
emkornfield wants to merge 3 commits into
apache:masterfrom
emkornfield:gold_integration_tests
Closed

ARROW-6318: [Integration] Run tests against pregenerated files#5272
emkornfield wants to merge 3 commits into
apache:masterfrom
emkornfield:gold_integration_tests

Conversation

@emkornfield

@emkornfield emkornfield commented Sep 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updates testing module to point to latest master which contains files
  • Refactors integration tests:
    • Move skips to use the build in skip functionality
    • generalize compare_implementation to a take a function to run tests

We could potentially provide more metadata as part of the checked in files, as this change relies a little too much on file name convention, but it does the jobs.

@emkornfield

emkornfield commented Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

Personal travis CI run: https://travis-ci.org/emkornfield/arrow/jobs/580759660

@codecov-io

codecov-io commented Sep 4, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@d818299). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5272   +/-   ##
=========================================
  Coverage          ?   89.07%           
=========================================
  Files             ?      885           
  Lines             ?   119797           
  Branches          ?     1437           
=========================================
  Hits              ?   106715           
  Misses            ?    12720           
  Partials          ?      362

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d818299...3c7d6f7. Read the comment docs.

@wesm

wesm commented Sep 5, 2019

Copy link
Copy Markdown
Member

Cool, looks good to me. We need to remove the use of --gold_dirs from the integration test Travis script before merging

@emkornfield

emkornfield commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

We need to remove the use of --gold_dirs from the integration test Travis script before merging

Don't we want to run this as part of travis? Could you elaborate?

@wesm

wesm commented Sep 5, 2019

Copy link
Copy Markdown
Member

I see, I thought this parameter was exclusive with the endogenous tests.

wesm
wesm approved these changes Sep 5, 2019
View reviewed changes

@wesm wesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I think soon we should refactor integration_test.py into a small Python package

@wesm

wesm commented Sep 5, 2019

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/ARROW-6466

@wesm wesm closed this in 26d72f3 Sep 5, 2019
@asfimport asfimport mentioned this pull request Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emkornfield @codecov-io @wesm